Blame view

buildroot/buildroot-2016.08.1/package/lirc-tools/0001-lib-use-proper-linking-method-to-avoid-parallel-buil.patch 1.59 KB
6b13f685e   김민수   BSP 최초 추가
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
  From f2fc8c48e5e55a91b309225f377b6cb3783fc6f6 Mon Sep 17 00:00:00 2001
  From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
  Date: Wed, 25 May 2016 15:21:57 +0200
  Subject: [PATCH] lib: use proper linking method to avoid parallel build issue
  
  Using <foo>_LDFLAGS = -l<library> is correct when <library> is an
  external library. However, when it is built by the same package, and
  especially in the same directory, this is wrong and can cause parallel
  build issues. In lib/Makefile.am, there was:
  
  libirrecord_la_LDFLAGS      = -llirc
  
  But the liblirc library is built in the same directory. Or, due to the
  using of <foo>_LDFLAGS, make is not aware of the build dependency
  between libirrecord and liblirc.
  
  To solve this, <foo>_LIBADD should be used instead, as follows:
  
  libirrecord_la_LIBADD       = liblirc.la
  
  This fixes parallel build issues seen by automated build tests
  conducted by the Buildroot project, such as:
  
    http://autobuild.buildroot.org/results/eb4/eb47d57de8182d25b1dacbf0ac3726ed20063d04/build-end.log
  
  Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
  ---
   lib/Makefile.am | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/lib/Makefile.am b/lib/Makefile.am
  index ce5c94c..8780f88 100644
  --- a/lib/Makefile.am
  +++ b/lib/Makefile.am
  @@ -29,7 +29,7 @@ liblirc_la_SOURCES          = config_file.c \
                                 transmit.c \
                                 util.c
   
  -libirrecord_la_LDFLAGS      = -llirc
  +libirrecord_la_LIBADD       = liblirc.la
   libirrecord_la_SOURCES      = irrecord.c
   
   liblirc_client_la_LDFLAGS   = -version-info 4:0:4
  -- 
  2.7.4